Skip to content

Port roi_align (CUDA) to stable ABI. - #9573

Merged
adabeyta merged 1 commit into
mainfrom
adabeyta/roi-align-cuda-stable
Aug 24, 2026
Merged

adabeyta merged 1 commit into
mainfrom
adabeyta/roi-align-cuda-stable

Conversation

@adabeyta

Copy link
Copy Markdown
Collaborator

Ports roi_align CUDA/ROCm kernels to the stable ABI.

Notes

  • Requires [Stable ABI] Move fastAtomicAdd to torch/headeronly. pytorch#191501.
  • Determinism layer change: The CUDA backward's at::globalContext().alertNotDeterministic call can't be made from a stable kernel, so it moves to the Python backward as torch._prims_common.alert_not_deterministic, gated to grad_output.device.type == "cuda". The CPU backward remains unchanged .

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit on a CUDA build. The counts don't move with this layer since the CUDA kernel's unstable references are all shared with the remaining legacy ops.

    Package: torchvision
      Torch ABI:   UNSTABLE
      CPython ABI: n/a
      Bundled libs: 3
      -- bundled libs --
        [UNSTABLE] [not-abi3] _C.so            (stable_shim=0,  unstable=103)
        [STABLE  ] [not-abi3] _C_stable.so     (stable_shim=70, unstable=0)
        [STABLE  ] [not-abi3] image_stable.so  (stable_shim=76, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9573

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Jul 30, 2026
@adabeyta
adabeyta changed the base branch from main to adabeyta/roi-align-cpu-stable July 30, 2026 21:27
Base automatically changed from adabeyta/roi-align-cpu-stable to main August 4, 2026 19:05
@NicolasHug
NicolasHug force-pushed the adabeyta/roi-align-cuda-stable branch from c76604f to bf0a70a Compare August 4, 2026 19:05
@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch from bf0a70a to 823ee29 Compare August 17, 2026 19:48
@adabeyta
adabeyta changed the base branch from main to adabeyta/roi-align-mps-stable August 17, 2026 20:42
@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch from 823ee29 to 5443e7f Compare August 17, 2026 20:53
@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch from 5443e7f to 492c79e Compare August 17, 2026 21:39
@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch from 492c79e to 5443e7f Compare August 17, 2026 21:56
Base automatically changed from adabeyta/roi-align-mps-stable to main August 18, 2026 23:00
@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch 2 times, most recently from c1fb40c to a04cebd Compare August 24, 2026 15:25
@adabeyta
adabeyta marked this pull request as ready for review August 24, 2026 16:29
@adabeyta adabeyta changed the title [Test] Port roi_align (CUDA) to stable ABI. Port roi_align (CUDA) to stable ABI. Aug 24, 2026
@adabeyta
adabeyta requested a review from NicolasHug August 24, 2026 16:29

@NicolasHug NicolasHug left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@adabeyta
adabeyta force-pushed the adabeyta/roi-align-cuda-stable branch from a04cebd to 9dd4643 Compare August 24, 2026 17:05
@adabeyta
adabeyta merged commit ff1a18d into main Aug 24, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants