Port roi_pool (MPS) to stable ABI. - #9583
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9583
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
99f447f to
4fd4d29
Compare
4fd4d29 to
1981680
Compare
1981680 to
68086b7
Compare
68086b7 to
fa35168
Compare
adabeyta
changed the title
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
alright I'll just believe you on this one :) ! Thanks @adabeyta
QQ since pytorch/pytorch#190932 has now merged, is there any cleanup we need to do to the existing stable MPS kernels? I might not remember correctly but I thought some of them might still launder raw scalar within 1-element tensors?
fa35168 to
e7fcbb6
Compare
Thanks! Yeah the MPS ports aren't as 1:1 as the CPU ones, the Metal encoder and dispatch calls all get reexpressed through the stable shim functions now so the old and new code don't line up side by side. As for cleanup after #190932 just nms carries iou_threshold in a 1-element tensor. Filed #9614 to clean that up! 😄 |
6e61e0f to
af8fb24
Compare
af8fb24 to
54a5492
Compare
2 participants
Ports
roi_pool's MPS kernels to the stable ABI.Notes
torch_mps_set_arg_bytes.roi_pool_metal_shader.h. Once every MPS op migrates, the per-op headers can consolidate to a mps_stable_kernels.h and mps_kernels.h gets dropped.