Port ps_roi_pool (MPS) to stable ABI. - #9618
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9618
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Unclassified FailureAs of commit 64d27fd with merge base d165b02 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
adabeyta
marked this pull request as ready for review
August 20, 2026 12:54
NicolasHug
approved these changes
Aug 20, 2026
NicolasHug
left a comment
Member
There was a problem hiding this comment.
Stamping, thanks @adabeyta !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports ps_roi_pool's MPS kernels to the stable ABI.
Notes
Stable-ABI audit (torch-abi-audit)
Ran torch-abi-audit. ps_roi_pool's MPS op moves into the fully-STABLE _C_stable.so and pulls in no new shim symbols. The unstable _C.so count is unchanged at 53: ps_roi_pool's MPS sources shared their unstable-API surface with the still-legacy kernels, so no symbol is uniquely removed until those migrate.