Skip to content

Codestyle: Type Hints (PEP 484) #470

Open

Description

@WhiteApfel

I want to work on async read/write (WIP #303) and see that there are no type hints in the code. Is it appropriate to add type hints, or is it better to stick with the current style?

Activity

  1. WhiteApfel commented on Feb 12, 2023

    @WhiteApfel
    Author

    I do not claim to work on full coverage of type hints, but I would like at least new functions or changed code to have such a convenient option.

  2. jonasmalacofilho commented on Feb 13, 2023

    @jonasmalacofilho
    Member

    I think type hints are desirable, in general and in this specific project.

    But I'm not sure it would be very useful to add them in just a few isolated places (and without our CI actually checking them).

  3. demberto commented on May 24, 2023

    @demberto

    I could work up on a PR, if one isn't already being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions