Skip to content

Remove the MINIMAL pragma from Pretty - #219

Merged
sjakobi merged 1 commit into
haskell-prettyprinter:masterfrom
dwincort:no-minimal-pragma-issue-218
Jun 7, 2022
Merged

sjakobi merged 1 commit into
haskell-prettyprinter:masterfrom
dwincort:no-minimal-pragma-issue-218

Conversation

@dwincort

@dwincort dwincort commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

This PR resolves #218.

@sjakobi
sjakobi requested a review from quchen January 4, 2022 16:17
@sjakobi

sjakobi commented Jan 4, 2022

Copy link
Copy Markdown
Collaborator

The build failure with GHC 7.4.2 is due to UnkindPartition/tasty#321. Unless that issue is resolved speedily, we can try to add to constraints locally to nudge tasty towards a good build plan, e.g. this one.

@sjakobi sjakobi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The build is fixed.

@dwincort

Copy link
Copy Markdown
Contributor Author

Any thoughts on getting this merged and pushed to hackage?

@sjakobi
sjakobi merged commit 898248f into haskell-prettyprinter:master Jun 7, 2022
@dwincort
dwincort deleted the no-minimal-pragma-issue-218 branch June 18, 2022 15:14
@dwincort
dwincort restored the no-minimal-pragma-issue-218 branch June 18, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect usage of MINIMAL pragma?

2 participants