Repository navigation
Add instance ann ~ Void => Pretty (Doc ann) - #234
Merged
Merged
Conversation
When there are no annotations, Doc is Pretty.
sjakobi
reviewed
Jan 16, 2023
| -- , (1, [2, 2, 2, 2, 2, 2, 2, 2]) ] ] | ||
|
|
||
| instance ann ~ Void => Pretty (Doc ann) where | ||
| pretty = vacuous |
Collaborator
There was a problem hiding this comment.
Doesn't vacuous perform useless work traversing the Doc?! It's implemented as fmap absurd.
How about this instead?!
Suggested change
| pretty = vacuous | |
| pretty = unsafeCoerce |
Contributor
Author
There was a problem hiding this comment.
pretty = unsafeCoerceYou forgot a two hundred word essay justifying it.
E.g. I'm not sure what happens when there are bottoms, annotate (error "surprise") doc :: Doc Void.
Contributor
Author
There was a problem hiding this comment.
To be clear: I won't author a commit with unsafeCoerce even fmap absurd is almost always can be replaced by it.
Contributor
Author
|
ping |
1 similar comment
Contributor
Author
|
ping |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no annotations, Doc is Pretty.