Skip to content

Fix of #243 (uncomment Pretty instances for {4,5,6,7}-tuple) - #275

Merged
sjakobi merged 5 commits into
haskell-prettyprinter:masterfrom
Ei30metry:i243
Feb 24, 2026
Merged

Fix of #243 (uncomment Pretty instances for {4,5,6,7}-tuple)#275
sjakobi merged 5 commits into
haskell-prettyprinter:masterfrom
Ei30metry:i243

Conversation

@Ei30metry

@Ei30metry Ei30metry commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fix of #243. The code was already there, so I just uncommented it.

@Ei30metry
Fix of haskell-prettyprinter#243 (uncomment Pretty instances for {4,5…
354c9b0 
…,6,7}-tuple)

The code was already there, so I just uncommented it.
@sjakobi

sjakobi commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

@Ei30metry

Ei30metry commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator Author

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.
Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.
Should I open a new issue for this?

@sjakobi

sjakobi commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.
Should I open a new issue for this?

I've made a PR: #276

@Ei30metry

Ei30metry commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

Should I open a new issue for this?

@Ei30metry

Ei30metry commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator Author

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

Should I open a new issue for this?

I just saw that you have done this.

@sjakobi
sjakobi merged commit 84f288d into haskell-prettyprinter:master Feb 24, 2026
16 checks passed
@sjakobi

sjakobi commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Thank you, @Ei30metry! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ei30metry @sjakobi