date_parse() (and friends) should get failure = c("warn", "error", "NA") #327

Activity

1. DavisVaughan

   added this to the 0.7.0 milestone on Apr 27, 2023
2. DavisVaughan

   removed this from the 0.7.0 milestone on May 10, 2023
3. DavisVaughan

   added

   featurea feature request or enhancementa feature request or enhancement

   on May 10, 2023
4. DavisVaughan commented on Jan 10, 2024

   

   DavisVaughan

   on Jan 10, 2024

   MemberAuthor

   More actions

   In some cases, we want to "try to parse" and detect which rows would fail to parse to identify them as "problems" (and maybe you'd throw those rows out entirely if they were problems), so we should provide some easy recipe for that, like:

   library(clock)
   
   date_parseable <- function(x,
                              ...,
                              format = NULL,
                              locale = clock_locale(),
                              missing = "allow") {
     missing <- rlang::arg_match(missing, values = c("allow", "reject"))
     
     # This is where we'd also make it silent, is this simply the easiest way?
     out <- suppressWarnings(
       date_parse(x, format = format, locale = locale),
       classes = "clock_warning_parse_failures"
     )
     
     problems <- switch(
       missing,
       allow = is.na(out) & !is.na(x),
       reject = is.na(out)
     )
     
     !problems
   }
   
   date_parseable(c("2019", "2020-01-01", NA))
   #> [1] FALSE  TRUE  TRUE
   date_parseable(c("2019", "2020-01-01", NA), missing = "reject")
   #> [1] FALSE  TRUE FALSE

   Providing a FAQ that does the parse and then does a check like this after the fact is probably better than exposing date_parseable() because we have so many parse variants we'd have to do it for.

   It would be nice to have date_parse(failure = c("warn", "error", "NA")) where we could explicitly set "NA" for silent NA propagation
5. DavisVaughan

   changed the title [-]`date_parse()` (and friends) argument to error on parse failure[/-] [+]`date_parse()` (and friends) should get `failure = c("warn", "error", "NA")`[/+] on Jan 10, 2024