Repository navigation
Conversation
Member
|
Does anyone use this URL parser? If it is really an issue, it would be better to zero-out the port vector, rather than guessing to fix the broken URL. Your current solution also escapes characters that should not be escaped so it is not a good solution. |
taekop
changed the title
Author
|
Agreed, I dropped the retry. The PR now only sets |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url_parse()skips the row whenxmlParseURI()returnsNULL, but theportvector is allocated without being initialised, so a URL libxml2 can't parse (e.g. one with a space or a non-ASCII character) came back with a garbageportsuch as-541335376. Such rows now getport = NA, matching the empty strings in the other columns.Closes #442