Repository navigation
Reject negative body size when parsing content headers (backport #2013) - #2014
Merged
Merged
Conversation
consumeHeaderFrame read the content header's body-size field as a signed long and only checked it against the configured maximum with `bodySize >= maxBodyLength`. A wire value with the high bit set decodes to a negative long, which always satisfies that comparison, bypassing the size check. The negative remainingBodyBytes then made the command complete with an empty body instead of throwing, so any body frames that followed were parsed as the start of a new command. Reject negative body sizes the same way oversized ones are already rejected. Add BrokenFramesTest#negativeBodySizeTriggersConnectionClosure. (cherry picked from commit f2f0a25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consumeHeaderFrame read the content header's body-size field as a signed long and only checked it against the configured maximum with
bodySize >= maxBodyLength. A wire value with the high bit set decodes to a negative long, which always satisfies that comparison, bypassing the size check. The negative remainingBodyBytes then made the command complete with an empty body instead of throwing, so any body frames that followed were parsed as the start of a new command.Reject negative body sizes the same way oversized ones are already rejected.
Add BrokenFramesTest#negativeBodySizeTriggersConnectionClosure.
This is an automatic backport of pull request #2013 done by Mergify.