Repository navigation
[3.2] Delegate keyword arguments in UploadedFile#method_missing - #2501
Merged
samuel-williams-shopify merged 1 commit intoAug 14, 2026
Merged
samuel-williams-shopify merged 1 commit into
samuel-williams-shopify merged 1 commit into
Conversation
Backport the fix from rack#2482 to Rack 3.2, retaining ruby2_keywords because the stable branch supports Ruby 2.4.
samuel-williams-shopify
force-pushed
the
backport-uploaded-file-keywords-3-2
branch
from
August 14, 2026 00:59
efe22f2 to
c2bf555
Compare
jeremyevans
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the
Rack::Multipart::UploadedFilekeyword-forwarding fix for #2481 to Rack 3.2.Rack 3.2 supports Ruby 2.4, so it cannot use the
...forwarding syntax adopted onmain. This instead uses the guardedruby2_keywordscompatibility mechanism from #2482, matching the other delegators on the stable branch. Ruby 2.4-2.6 retain their existing behavior, while Ruby 2.7+ correctly forwards keyword arguments.The original authorship and changelog credit for @SeanLF are preserved.
Verification
bundle exec ruby -Itest test/spec_multipart.rb -n "/delegates keyword arguments/"bundle exec ruby -Itest test/spec_multipart.rb(100 runs, 332 assertions)git diff --check