Skip to content

src/update_handler: emmc: allow bootloader updates, if user partition was active - #2020

Open
MatthiasWauer wants to merge 1 commit into
rauc:masterfrom
KLSMartin:bugfix/allow-bootloader-updates-on-user-partition
Open

MatthiasWauer wants to merge 1 commit into
rauc:masterfrom
KLSMartin:bugfix/allow-bootloader-updates-on-user-partition

Conversation

@MatthiasWauer

Copy link
Copy Markdown

Commit 7a46327 (src/emmc: error-out for invalid bootpart in r_emmc_read_bootpart()) changed the behaviour to disallow bootloader updates in case the user partition was currently active.

The change restores the behaviour to allow that and log a warning only. Also match the implementation detail, that the boot partition 1 is used in that case.

Fixes: #2017

@codecov

codecov Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.88%. Comparing base (98adedb) to head (a899bec).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/update_handler.c 14.28% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (14.28%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   84.89%   84.88%   -0.02%     
==========================================
  Files          77       77              
  Lines       23383    23387       +4     
==========================================
  Hits        19851    19851              
- Misses       3532     3536       +4     
Flag Coverage Δ
service=false 79.47% <14.28%> (-0.02%) ⬇️
service=true 84.86% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/update_handler.c Outdated
@ejoerns ejoerns added this to the Release v1.16 milestone Aug 3, 2026
… was active

Commit 7a46327 (src/emmc: error-out for invalid bootpart in r_emmc_read_bootpart())
changed the behaviour to disallow bootloader updates in case the
user partition was currently active.

The change restores the behaviour to allow that and log a warning only.
Also match the implementation detail, that the boot partition 1 is used
in that case.

Signed-off-by: Matthias Wauer <[email protected]>
@MatthiasWauer
MatthiasWauer force-pushed the bugfix/allow-bootloader-updates-on-user-partition branch from 7da5317 to a899bec Compare August 3, 2026 10:43
@MatthiasWauer
MatthiasWauer requested a review from ejoerns August 4, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow type=boot-emmc bootloader updates while EMMC user parition is in use.

2 participants