Repository navigation
Conversation
Signed-off-by: zayeem shaikh <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
- Coverage 84.93% 84.92% -0.01%
==========================================
Files 77 77
Lines 23431 23456 +25
==========================================
+ Hits 19902 19921 +19
- Misses 3529 3535 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hash_file() derives the progress-reporting interval as count / (R_HASH_INDEX_GEN_PROGRESS_SPAN - 1) and uses it as a modulo divisor once per chunk, so building the index for an image with fewer than nine 4k chunks while a progress step is active divides by zero (SIGFPE on x86, and the undefined behaviour is flagged by the UBSan job). This computes the interval once before the loop and clamps it to at least one chunk, the same zero guard r_copy_stream_with_progress() already has. The added hash_index test builds an index for a single-chunk image with progress enabled, which reviewers can run to confirm it no longer traps.