Repository navigation
Add context propagation to rclone - #3267
Merged
Merged
Conversation
golangcibot
reviewed
Jun 17, 2019
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
- Change rclone/fs interfaces to accept context.Context - Update interface implementations to use context.Context - Change top level usage to propagate context to lover level functions Context propagation is needed for stopping transfers and passing other request-scoped values.
ajankovic
force-pushed
the
ajankovic/propagate_context
branch
from
June 17, 2019 09:07
83b86d4 to
b38fc40
Compare
Member
|
Thank you for this, will merge now :-) Alas it is going to break a lot of pending changes, but that can't be helped :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Context propagation is needed for stopping transfers and passing other request-scoped values.
Fixes: #3257