Repository navigation
docker: add mailcap for /etc/mime.types - fixes #6384 - #9977
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
The Docker image has no /etc/mime.types, so MIME types come only from Go's
built-in table plus rclone's small extra list, and many extensions upload as
application/octet-stream. This installs Alpine's mailcap package, as
suggested in the issue.
Checked by running
rclone lsf --format pmover one file per extensionlisted in mime.types (1393 extensions):
.m4v, .flv, .aac, .woff2, .deb now get real types)
As on any Linux host with mime.types, the system file takes precedence, so a
few types change: .ts becomes text/vnd.trolltech.linguist (was video/MP2T),
.flac audio/x-flac, .wav audio/x-wav. If keeping video/MP2T for .ts matters,
I can add an override to fs/mimetype.go.
Was the change discussed in an issue or in the forum before?
Fixes #6384
Checklist