Skip to content

Commit 02f4115

Browse files
acdliteacdlite
authored
Upgrade useInsertionEffect to stable (#22589)
@huozhi tried this out and says it's working as expected. I think we can go ahead and move this into the stable channel, so that it is available in the React 18 alpha releases.
1 parent b81de86 commit 02f4115

9 files changed

Lines changed: 9 additions & 15 deletions

File tree

‎packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,8 @@ describe('ReactHooksInspectionIntegration', () => {
268268
]);
269269
});
270270

271-
// @gate experimental || www
272271
it('should inspect the current state of all stateful hooks, including useInsertionEffect', () => {
273-
const useInsertionEffect = React.unstable_useInsertionEffect;
272+
const useInsertionEffect = React.useInsertionEffect;
274273
const outsideRef = React.createRef();
275274
function effect() {}
276275
function Foo(props) {

‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function initModules() {
5555
useRef = React.useRef;
5656
useDebugValue = React.useDebugValue;
5757
useImperativeHandle = React.useImperativeHandle;
58-
useInsertionEffect = React.unstable_useInsertionEffect;
58+
useInsertionEffect = React.useInsertionEffect;
5959
useLayoutEffect = React.useLayoutEffect;
6060
useOpaqueIdentifier = React.unstable_useOpaqueIdentifier;
6161
forwardRef = React.forwardRef;
@@ -641,7 +641,6 @@ describe('ReactDOMServerHooks', () => {
641641
});
642642
});
643643
describe('useInsertionEffect', () => {
644-
// @gate experimental || www
645644
it('should warn when invoked during render', async () => {
646645
function Counter() {
647646
useInsertionEffect(() => {

‎packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe('ReactHooksWithNoopRenderer', () => {
4747
useState = React.useState;
4848
useReducer = React.useReducer;
4949
useEffect = React.useEffect;
50-
useInsertionEffect = React.unstable_useInsertionEffect;
50+
useInsertionEffect = React.useInsertionEffect;
5151
useLayoutEffect = React.useLayoutEffect;
5252
useCallback = React.useCallback;
5353
useMemo = React.useMemo;
@@ -2685,7 +2685,6 @@ describe('ReactHooksWithNoopRenderer', () => {
26852685
});
26862686

26872687
describe('useInsertionEffect', () => {
2688-
// @gate experimental || www
26892688
it('fires insertion effects after snapshots on update', () => {
26902689
function CounterA(props) {
26912690
useInsertionEffect(() => {
@@ -2745,7 +2744,6 @@ describe('ReactHooksWithNoopRenderer', () => {
27452744
});
27462745
});
27472746

2748-
// @gate experimental || www
27492747
it('fires insertion effects before layout effects', () => {
27502748
let committedText = '(empty)';
27512749

@@ -2808,7 +2806,6 @@ describe('ReactHooksWithNoopRenderer', () => {
28082806
expect(Scheduler).toHaveYielded(['Destroy passive [current: 0]']);
28092807
});
28102808

2811-
// @gate experimental || www
28122809
it('force flushes passive effects before firing new insertion effects', () => {
28132810
let committedText = '(empty)';
28142811

@@ -2876,7 +2873,6 @@ describe('ReactHooksWithNoopRenderer', () => {
28762873
]);
28772874
});
28782875

2879-
// @gate experimental || www
28802876
it('fires all insertion effects (interleaved) before firing any layout effects', () => {
28812877
let committedA = '(empty)';
28822878
let committedB = '(empty)';
@@ -3043,7 +3039,6 @@ describe('ReactHooksWithNoopRenderer', () => {
30433039
});
30443040
});
30453041

3046-
// @gate experimental || www
30473042
it('assumes insertion effect destroy function is either a function or undefined', () => {
30483043
function App(props) {
30493044
useInsertionEffect(() => {

‎packages/react/index.classic.fb.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export {
4848
useEffect,
4949
useImperativeHandle,
5050
useLayoutEffect,
51-
unstable_useInsertionEffect,
51+
useInsertionEffect,
5252
useMemo,
5353
useMutableSource,
5454
useMutableSource as unstable_useMutableSource,

‎packages/react/index.experimental.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export {
4242
useDeferredValue,
4343
useEffect,
4444
useImperativeHandle,
45-
unstable_useInsertionEffect,
45+
useInsertionEffect,
4646
useLayoutEffect,
4747
useMemo,
4848
useMutableSource as unstable_useMutableSource,

‎packages/react/index.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export {
6767
useDeferredValue,
6868
useEffect,
6969
useImperativeHandle,
70-
unstable_useInsertionEffect,
70+
useInsertionEffect,
7171
useLayoutEffect,
7272
useMemo,
7373
useMutableSource,

‎packages/react/index.modern.fb.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export {
4646
useDeferredValue as unstable_useDeferredValue, // TODO: Remove once call sights updated to useDeferredValue
4747
useEffect,
4848
useImperativeHandle,
49-
unstable_useInsertionEffect,
49+
useInsertionEffect,
5050
useLayoutEffect,
5151
useMemo,
5252
useMutableSource,

‎packages/react/index.stable.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export {
3636
useDeferredValue,
3737
useEffect,
3838
useImperativeHandle,
39+
useInsertionEffect,
3940
useLayoutEffect,
4041
useMemo,
4142
useMutableSource as unstable_useMutableSource,

‎packages/react/src/React.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export {
9292
useEffect,
9393
useImperativeHandle,
9494
useDebugValue,
95-
useInsertionEffect as unstable_useInsertionEffect,
95+
useInsertionEffect,
9696
useLayoutEffect,
9797
useMemo,
9898
useMutableSource,

0 commit comments

Comments
 (0)