Repository navigation
Fix local react usage in DOM fixture - #32080
Merged
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 87276ef1efb340467563c107f24248653d7f7f00...6dc099ea34635610dc5b207d538968ad5867cf57 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
approved these changes
Jan 15, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DOM fixture hasn't worked on local builds since the UMD support was removed in #28735
Here we update the fixture to set the local experimental builds to window. Some of the pages are still broken, such as hydration. But these bugs exist on other versions as well and can be cleaned up separately.