Repository navigation
[ci] Reject focused Playwright tests in Flight fixture - #37757
Merged
Merged
Conversation
Set forbidOnly to isCI so CI rejects accidentally committed .only tests instead of silently excluding other tests. Allow focused debugging locally, matching the existing configuration comment.
|
Comparing: 278794d...b08fd79 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) Generated by sizebot against b08fd79 |
|
react 3d add |
eps1lon
changed the title
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the Flight fixture’s
forbidOnlyfrom!isCItoisCIto reject.onlyon CI and allow focused debugging locally. This prevents CI from passing while accidentally excluding other tests and matches the existing comment.The inverted condition dates to #28350.
How did you test this change?
test.only()and confirmedCI=true yarn testrejects it with exit code1..onlyand ran the full Flight fixture suite from the repository root: