Skip to content

Allows editing of start/end tag simultaneously - #207

Merged
fbricon merged 1 commit into
redhat-developer:masterfrom
xorye:matchingTagClient
Dec 13, 2019
Merged

fbricon merged 1 commit into
redhat-developer:masterfrom
xorye:matchingTagClient

Conversation

@xorye

@xorye xorye commented Dec 13, 2019

Copy link
Copy Markdown

Fixes #130, branched off the branch from #204

This PR updates the cursor(s) when toggling the config

Signed-off-by: Nikolas Komonen [email protected]

@fbricon

fbricon commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

when no folder/workspace is opened, if you edit an xml file, the toggle command doesn't work
If a pref key exists in the workspace, then toggling mirror mode should change it, else, set the preference at the user level

@xorye

xorye commented Dec 13, 2019

Copy link
Copy Markdown
Author

@fbricon updated

@fbricon

fbricon commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

says "Toggled the xml.matchingTagEditing preference in the Workspace settings.", even though there's no workspace

Under the preference xml.autoSelectingMatchingTags

Fixes #130

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon
fbricon merged commit 9f32fc1 into redhat-developer:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto Rename Tag

3 participants