Repository navigation
Update vscode-languageclient to 7.0.0 - #432
Merged
angelozerr merged 1 commit intoApr 16, 2021
Merged
Conversation
Contributor
|
I think you can switch your draft PR in real PR. |
datho7561
marked this pull request as ready for review
April 14, 2021 13:13
datho7561
force-pushed
the
linked-editing-support
branch
from
April 14, 2021 13:20
533ff94 to
f8ba051
Compare
This allows for `textDocument/linkedEditingRange` to be used. Replaces redhat-developer#426 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
linked-editing-support
branch
from
April 14, 2021 19:44
f8ba051 to
0c3516f
Compare
Contributor
|
I'm really annoying because this PR works good with master of LemMinx but with the Leinked Editing range PR eclipse-lemminx/lemminx#991 (even if linked editing range is disable) the server crashes (no completion, no validation, etc) |
Contributor
Author
|
I also get this. I'll play around with this a bit today to see if I can figure out what's going on. |
angelozerr
approved these changes
Apr 16, 2021
Contributor
|
This PR works great with LemMinx and with LSP4J 0.9 (master) and 0.11 but not for 0.12. As it's not a problem coming from this PR, I merge it. If 0.12 have a problem we can use 0.11 for linked editing range support. Thanks @datho7561 ! |
This was referenced Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for
textDocument/linkedEditingRangeto be used.Replaces #426
Signed-off-by: David Thompson [email protected]