Repository navigation
gitnr search view reacts to both Press and Release events #3
Description
Activity
- added a commit that references this issue
on Sep 12, 2023 Hey, thanks for the heads-up and providing the relevant docs.
Didn't notice that at all. Thankfully, I think the fix was quite simple (7dffa5b).
I also enabled
event.kindfor Unix systems as well, so things are consistent across platforms.The new release v0.1.1 has that fix.
Let me know if it works fine, I don't use Windows and as such can't test it out easily.
Hey, thanks for reacting so quickly. The new version actually doesn't work now hah. Screenshot below:
I think you might need to gate the
pushandpopofKeyboardEnhancementFlags, maybe behind cfg(not(windows)), I'm not sure on the syntax. But the rest of the commit looks correct. This is probably because, as the crossterm docs say, it's always enabled for Windows and the enhancement flags don't exist.PS: would you consider publishing to crates.io? It would allow for installation via cargo-binstall too, since it pulls metadata from there to then locate the GitHub release url.
My bad mate...lol. Thanks for showing the error and pointing me in the right direction.
Managed to fix that issue and tested it in my Windows VM. Also managed to fix a few other issues too.
Release v0.1.3 is available now.
I've also set up the GH action to publish the crate, so it's available on crates.io now. I've also configured it to work with
cargo-binstallas well. Check out the README for more info on the new install methods.Reacted by Aadi Desai
In
fn handle_key_events(here), theevent.kindis not checked with keyboard input.I think this event is created when pressing and releasing a key, so every key is reacted to twice. Trying to select using enter selects and then unselects, or using arrow keys moves 2 items at a time.
This is on Windows, but looking at the crossterm docs, the event kind needs to be opted-in for unix systems so it might not happen for you.