Repository navigation
Conversation
|
The commitlint failure is because your commit message starts with a capital. |
6997a66 to
85eae44
Compare
That's funny. i was looking at the recent history on the repo to comply to the commit-messages. |
|
We capitalise everything anyway when it goes into the changelog: The linter is probably a bit too strict. Anyway, these changes look good. Have you tested this in commit-mode too? |
i tested this locally with |
|
I believe this PR might also solve #362 ? |
|
@betaboon Please can you rebase this to fix the conflicts. I will merge once that is done. |
|
I'm not close to a computer for the next couple of weeks. |
|
+1 to this branch. I am also being impacted by #362, which this solves. |
|
I just tried rebasing this branch, but there are some conflicts that I'm unsure about, that are the result of #488 |
85eae44 to
b8a56a8
Compare
resolves #171
i tested this locally.
the whole-testsuite seems to still pass.
i have no clue how to test this with the given test-infrastructure tho.
suggestions and contributions to cover this with tests are highly welcome