Repository navigation
Reject concurrent reuse of active handler IDs - #738
Merged
adrianlyjak merged 1 commit intoAug 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: fec5803 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Whxuan0701
marked this pull request as ready for review
August 18, 2026 09:52
Contributor
|
Thanks, this is great. I've been meaning to add this. Another related functionality to this is to be able to specify a run ID for idempotency. In that case, I think we can just return some sort of 200 response if the run ID already exists and skip the 409. But this is a great first step . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
409 Conflictwith a stable, actionable error from both blocking and non-blocking run endpointsllama-agents-serverValidation
uv run pytest packages/llama-agents-server/tests -n0(447 passed, 32 deselected)uv run pytest packages/llama-agents-appserver/tests -n0(107 passed)uv run ruff format --check packages/llama-agents-server/src/llama_agents/server packages/llama-agents-server/tests/serveruv run ruff check packages/llama-agents-server/src/llama_agents/server packages/llama-agents-server/tests/serveruv run ty check packages/llama-agents-server/src/llama_agents/server/_service.py packages/llama-agents-server/src/llama_agents/server/_api.py packages/llama-agents-server/tests/server/test_server_endpoints.pygit diff --check origin/main...HEADKnown gaps
The store lookup and handler creation are not a cross-process compare-and-set operation. This change closes the existing HTTP service path mismatch and does not claim distributed atomicity.
The full-repository pre-commit run could not complete locally because the workspace environment does not include optional AgentCore, Control Plane, and llamactl dependencies. The checks scoped to the affected server and appserver packages pass.