Update read_buf API to match current nightly - #3102
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
ctz
approved these changes
Jun 22, 2026
ctz
left a comment
ctz
left a comment
Member
There was a problem hiding this comment.
One thing we might consider here is withdrawing some of the more noisy/long-term-investment-in-quality CI items for release branches? Like nightly clippy.
Member
Author
Dropped the nightly Clippy job. |
This test was only fetching ECH config data from DNS and then checking we could unmarshal it. The daily tests CI is now configured to use the full-fledged ech-example.rs binary for the same test sites. Doing that _also_ tests the DNS ECH config list handling, but goes further and uses the unmarshalled configs for a real ECH enabled handshake. We can delete these tests on the back of that improved end-to-end coverage.
The libcrux crates have fixed this upstream but a release may not be available for some time. Ignore the unmaintained transitive dep warning for now.
cpu
approved these changes
Jun 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel-0.23 #3102 +/- ##
=========================================
Coverage 95.31% 95.31%
=========================================
Files 97 97
Lines 21940 21942 +2
=========================================
+ Hits 20912 20914 +2
Misses 1028 1028 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.