0.23: verify server certificate against correct name on ECH rejection - #3236
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
rustfmt cannot format matches arms with interior comments, so silently refuses to process the file. So delete the single comment. Very normal.
ctz
force-pushed
the
jbp-0.23-ech-testing
branch
2 times, most recently
from
August 31, 2026 10:33
642921b to
6ad099f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-0.23 #3236 +/- ##
============================================
- Coverage 95.35% 95.35% -0.01%
============================================
Files 98 97 -1
Lines 22034 22033 -1
============================================
- Hits 21011 21010 -1
Misses 1023 1023 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This enables and fixes TLS-ECH-Client-Reject-OverrideName-TLS13.
ctz
force-pushed
the
jbp-0.23-ech-testing
branch
from
August 31, 2026 10:57
6ad099f to
4e0776c
Compare
djc
approved these changes
Aug 31, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re #3235