0.23.45: Ensure handshake "alignment" check covers previously-received messages - #3265
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-0.23 #3265 +/- ##
=========================================
Coverage 95.14% 95.14%
=========================================
Files 97 97
Lines 21931 21932 +1
=========================================
+ Hits 20866 20867 +1
Misses 1065 1065 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
approved these changes
Sep 13, 2026
Incorporate test case from GHSA-2mjx-qc3c-rqvc POC, plus three more limited tests.
ctz
force-pushed
the
jbp-0.23-hs-aligned-fully-received
branch
from
September 14, 2026 12:23
3189b8b to
a1293d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes (and text for pending RUSTSEC)
Bug fix: TLS 1.3 handshake messages incorrectly accepted across encryption level boundaries
Rustls accepted TLS 1.3 handshake messages sent at the wrong encryption level when they followed a key-changing message in the same record. The handshake transcript is still authenticated, so a network-position attacker cannot use this to alter or complete a handshake; the practical effect is that a peer could send handshake messages that should be encrypted in plaintext without rustls rejecting the connection.
This issue is tracked as GHSA-2mjx-qc3c-rqvc. This issue affects rustls versions 0.23.13 through 0.23.44 inclusive.
Note that this is functionally the same bug as GO-2026-4340.