chore(dev): consolidate checks behind just by ryoppippi · Pull Request #1240 · ccusage/ccusage

ryoppippi · 2026-06-09T08:56:08Z

Consolidates contributor-facing development validation around just.

This makes just check run package typechecks plus nix flake check, which covers treefmt, oxlint, clippy, schema drift, gitleaks, and the build. It also adds just update-litellm-pricing and updates the README, installation guide, and pricing update workflow to use the same entry points.

Testing:

nix develop --command just check

Summary by CodeRabbit

Documentation
- Updated developer and contributor setup docs to reflect the new Nix-based dev environment and revised task examples, and clarified the pricing update process.
Chores
- Adjusted scheduled pricing snapshot refresh to open PRs when the locked snapshot changes.
- Updated validation workflow and top-level development task orchestration.
New Features
- Added an automated task to update LiteLLM pricing snapshots.

Make just check the main static validation entry point by running lint, format checks, typechecks, and nix flake check. Add a just update-litellm-pricing recipe so the README and scheduled pricing workflow can describe validation through just instead of direct nix commands.

cloudflare-workers-and-pages · 2026-06-09T08:56:13Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	ccusage-guide	`562b512`	Commit Preview URL Branch Preview URL	Jun 09 2026, 08:58 AM

coderabbitai · 2026-06-09T08:56:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aae10a2e-b14d-448e-b808-cc5287602ef2

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca2abb and 562b512.

📒 Files selected for processing (1)

justfile

📝 Walkthrough

Walkthrough

Routes project validation and developer tasks through a top-level justfile. The pricing-update workflow now runs nix develop --command just check. Documentation and contributor install instructions were updated to use the Nix dev shell (direnv) and just task names (including just update-litellm-pricing).

Changes

Development Tooling Centralization

Layer / File(s)	Summary
Justfile recipes and task wiring `justfile`	Updates `check` to depend on `typecheck`, retains `schema`, and adds `update-litellm-pricing` which runs `nix flake update litellm` then `just check`.
GitHub Actions workflow validation `.github/workflows/update-pricing.yaml`	Workflow validation step and PR body updated to run `nix develop --command just check` and document `- just check` in the PR body.
Contributor and installation docs `apps/ccusage/README.md`, `docs/guide/installation.md`	Docs now instruct `direnv allow` to load the Nix dev shell, enumerate common `just` tasks (`just format`, `just test`, `just check`, `just build`), change examples from `just typecheck`→`just check`, add `just update-litellm-pricing`, and remove an explicit `pnpm install` step.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ryoppippi/ccusage#1077: Overlaps updates to the Nix-based contributor setup docs (nix-direnv/direnv allow) in apps/ccusage/README.md.
ryoppippi/ccusage#1238: Related adjustments to the repo justfile workflows and check/validation patterns centralizing dev/CI commands.
ryoppippi/ccusage#1057: Also modifies the LiteLLM pricing automation workflow (.github/workflows/update-pricing.yaml) and validation command.

Poem

🐰 I hopped into the justfile glade,

Commands now tidy where I once strayed,
A dev-shell snug with tools in tow,
just check hums steady, nice and slow,
Happy carrots for a cleaner flow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore(dev): consolidate checks behind just' accurately summarizes the main change: standardizing development validation by consolidating various checks (lint, format, typecheck, nix flake check) behind the just task runner.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/use-just-contributor-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Rely on nix flake check for treefmt and oxlint, while keeping package typechecks as the extra just check dependency.

ryoppippi · 2026-06-09T08:59:02Z

@coderabbitai review

Please review the latest push. Validation run locally:

agent-skills: installed to /Users/ryoppippi/ghq/github.com/ryoppippi/ccusage/.claude/skills

ryoppippi · 2026-06-09T08:59:14Z

@coderabbitai review

Please review the latest push. Local validation passed: nix develop --command just check

coderabbitai · 2026-06-09T08:59:25Z

@ryoppippi Sure, I'll review the latest push now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-06-09T08:59:58Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get PR details and changed files
gh pr view 1240 --repo ryoppippi/ccusage --json title,body,state,headRefName,baseRefName,files
echo "---FILES---"
gh pr diff 1240 --repo ryoppippi/ccusage

Length of output: 6038

@ryoppippi: I've reviewed the latest push. The changes are clean and well-coordinated across all four files. Here's a summary of my findings:

justfile

check: typecheck correctly sequences package typechecks before nix flake check, and the updated comment accurately describes both.
update-litellm-pricing is self-contained and mirrors the old manual steps (nix flake update litellm + validation), now behind a single recipe.

.github/workflows/update-pricing.yaml

Switching from nix flake check to nix develop --command just check adds the typecheck prerequisite in CI, making the scheduled workflow match the contributor entry-point exactly. The extra cost is acceptable for a scheduled job.

apps/ccusage/README.md / docs/guide/installation.md

Both docs are now consistent with the justfile surface (just fmt, just test, just check, just build).
Removing the explicit pnpm install step from the installation guide is correct since the Nix dev shell handles it automatically.
Replacing the raw nix flake update litellm && nix flake check sequence with just update-litellm-pricing is a clean simplification.

No issues found. The consolidation is logically consistent across all files.

[approve]

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

pullfrog

✅ No new issues found.

Reviewed changes — consolidates contributor-facing dev validation behind just recipes, replacing direct nix flake check / nix flake update litellm calls with just check and just update-litellm-pricing.

Make just check run typechecks before flake checks — adds typecheck as a dependency in justfile, so just check covers pnpm typechecking plus treefmt/oxlint/clippy/schema/gitleaks/build
Add just update-litellm-pricing recipe — combines nix flake update litellm with just check as a single command
Update pricing CI workflow — replaces nix flake check with nix develop --command just check and updates the PR body validation note
Document just as the contributor entry point — updates apps/ccusage/README.md and docs/guide/installation.md to show just fmt / just test / just check / just update-litellm-pricing

^{｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏}

pkg-pr-new · 2026-06-09T09:04:08Z

Open in StackBlitz

ccusage

npx https://pkg.pr.new/ccusage@1240

@ccusage/ccusage-darwin-arm64

npx https://pkg.pr.new/@ccusage/ccusage-darwin-arm64@1240

@ccusage/ccusage-darwin-x64

npx https://pkg.pr.new/@ccusage/ccusage-darwin-x64@1240

@ccusage/ccusage-linux-arm64

npx https://pkg.pr.new/@ccusage/ccusage-linux-arm64@1240

@ccusage/ccusage-linux-x64

npx https://pkg.pr.new/@ccusage/ccusage-linux-x64@1240

@ccusage/ccusage-win32-arm64

npx https://pkg.pr.new/@ccusage/ccusage-win32-arm64@1240

@ccusage/ccusage-win32-x64

npx https://pkg.pr.new/@ccusage/ccusage-win32-x64@1240

commit: 562b512

cubic-dev-ai

No issues found across 4 files

_{Re-trigger cubic}

chore(dev): avoid duplicate check steps

562b512

Rely on nix flake check for treefmt and oxlint, while keeping package typechecks as the extra just check dependency.

cubic-dev-ai Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread justfile

pullfrog Bot approved these changes Jun 9, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Jun 9, 2026

View reviewed changes

ryoppippi merged commit ddaf459 into main Jun 9, 2026
37 of 39 checks passed

ryoppippi deleted the codex/use-just-contributor-workflow branch June 9, 2026 09:31

This was referenced Jun 9, 2026

feat(pricing): embed models.dev snapshot for offline pricing #1242

Merged

fix(nix): stabilise crane dependency cache #1243

Merged

Conversation

ryoppippi commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

ryoppippi commented Jun 9, 2026

Uh oh!

ryoppippi commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ryoppippi commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

cloudflare-workers-and-pages Bot commented Jun 9, 2026 •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

pkg-pr-new Bot commented Jun 9, 2026 •

edited

Loading