Skip to content

Increase color contrast in footer - #459

Merged
jarrodmillman merged 1 commit into
scientific-python:mainfrom
jarrodmillman:footer-links
Jan 26, 2024
Merged

jarrodmillman merged 1 commit into
scientific-python:mainfrom
jarrodmillman:footer-links

Conversation

@jarrodmillman

Copy link
Copy Markdown
Member

Fix #457. I am using the same hoover color as used in the about button and news banner.

2024-01-26T08:22:48,295534305-08:00

https://coolors.co/contrast-checker/4dabcf-013243

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Jan 26, 2024
@netlify

netlify Bot commented Jan 26, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b5aa085
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65b3dc890564f700086d5467
😎 Deploy Preview https://deploy-preview-459--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman

Copy link
Copy Markdown
Member Author

I am going to merge this and close the issue. This is much better than what we had, but we still need to revisit this when we do our accessibility audit.

@jarrodmillman
jarrodmillman merged commit 5674a9c into scientific-python:main Jan 26, 2024
@jarrodmillman
jarrodmillman deleted the footer-links branch January 26, 2024 17:35
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jan 26, 2024
@melissawm

Copy link
Copy Markdown
Member

Thanks for the swift response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color contrast on page footer

3 participants