Skip to content

MAINT: Need to be explicit with action path while using pixi run too - #98

Merged
matthewfeickert merged 1 commit into
mainfrom
pixi_run_manifest
Sep 30, 2024
Merged

MAINT: Need to be explicit with action path while using pixi run too#98
matthewfeickert merged 1 commit into
mainfrom
pixi_run_manifest

Conversation

@MridulS

@MridulS MridulS commented Sep 30, 2024 •
edited by matthewfeickert
Loading

Copy link
Copy Markdown
Member

I missed this in #96 but we need to be explicit while using pixi run too.

I was tripping into could not find pixi.toml or pyproject.toml which is configured to use pixi while on the pixi run step downstream.

I can use scipp/scipp#3542 to test this outside of this repo. I'll ping here once that passes :)

* Provide '--manifest-path' option to 'pixi run' to ensure the environment is properly activated.

      --manifest-path <MANIFEST_PATH>
          The path to 'pixi.toml' or 'pyproject.toml'

@MridulS
MAINT: Need to be explicit with action path while using pixi run too
3fcd15d 
I missed this in #96 but we need to be explicit while using `pixi run` too.

I was tripping into `could not find pixi.toml or pyproject.toml which is configured to use pixi` while on the `pixi run` step downstream.
@MridulS
MridulS temporarily deployed to remove-old-wheels September 30, 2024 15:46 — with GitHub Actions Inactive
@matthewfeickert

matthewfeickert commented Sep 30, 2024

Copy link
Copy Markdown
Member

I can use scipp/scipp#3542 to test this outside of this repo. I'll ping here once that passes :)

Thank you @MridulS. If I'm not immediately responsive please merge if things pass there.

@matthewfeickert

matthewfeickert commented Sep 30, 2024

Copy link
Copy Markdown
Member

@MridulS The action worked for you. 👍

Your workflow failed

  while read -r package_name; do
    echo "Removing $package_name"
    pixi run anaconda --token "***" remove -f "$package_name"
  done < dev_wheels.txt
  shell: /usr/bin/bash -l {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.15/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib
Removing scipp-nightly-wheels/scipp/24.9.2.dev8+g7d0cce6be
  × could not find pixi.toml or pyproject.toml which is configured to use pixi

but that's because in your PR you're trying to use pixi locally without any configs:

      - name: Delete old dev wheels from pypi.anaconda.org
        run: |
          while read -r package_name; do
            echo "Removing $package_name"
            pixi run anaconda --token "${{secrets.ANACONDA_NIGHTLY_WHEEL_TOKEN}}" remove -f "$package_name"
          done < dev_wheels.txt

@matthewfeickert
matthewfeickert merged commit 82396a2 into main Sep 30, 2024
@matthewfeickert
matthewfeickert deleted the pixi_run_manifest branch September 30, 2024 16:03
@matthewfeickert matthewfeickert mentioned this pull request Sep 30, 2024
Merged

This branch was previously deployed

1 inactive deployment
remove-old-wheels — 3fcd15dc Deployed Sep 30, 2024 by MridulS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanv stefanv stefanv approved these changes
@matthewfeickert matthewfeickert matthewfeickert approved these changes

Assignees

@MridulS MridulS

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MridulS @matthewfeickert @stefanv