Skip to content

[ESSREFLECTOMETRY] fix: add reference for metadata - #741

Merged
jokasimr merged 4 commits into
mainfrom
fix-gui
Sep 11, 2026
Merged

jokasimr merged 4 commits into
mainfrom
fix-gui

Conversation

@jokasimr

@jokasimr jokasimr commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

The gui could not run the reduction because of a change to the workflow that was not catched (the gui had no tests).

This PR fixes the issue and adds a small test so that it is slightly harder to break in the future.
I also made the docs page actually display what the UI looks like when it is used, to make the page a bit more interesting.

@github-actions github-actions Bot added the essreflectometry Issues for essreflectometry. label Sep 10, 2026
@github-actions github-actions Bot changed the title fix: add reference for metadata [ESSREFLECTOMETRY] fix: add reference for metadata Sep 10, 2026
@jokasimr
jokasimr marked this pull request as ready for review September 10, 2026 12:48
@YooSunYoung

Copy link
Copy Markdown
Member

The PR diff renders weird today... but overall it looks good to me.

The CI fail seems like due to outage of public.esss.dk . I reran one of them and it passed.
Will you update branch and trigger the tests again?

@jokasimr
jokasimr added this pull request to the merge queue Sep 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 11, 2026
@jokasimr
jokasimr added this pull request to the merge queue Sep 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 11, 2026
@jokasimr
jokasimr added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 2e2cc18 Sep 11, 2026
24 checks passed
@jokasimr
jokasimr deleted the fix-gui branch September 11, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

essreflectometry Issues for essreflectometry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants