Repository navigation
Conversation
MridulS
reviewed
Mar 31, 2026
MridulS
left a comment
MridulS
left a comment
Member
There was a problem hiding this comment.
LGTM but not sure about the deepcopy semantics while copying over things from cpp world to python.
SimonHeybrock
changed the title
jl-wynen
approved these changes
Apr 7, 2026
jl-wynen
left a comment
jl-wynen
left a comment
Member
There was a problem hiding this comment.
LGTM but not sure about the deepcopy semantics while copying over things from cpp world to python.
It's ok. The lambdas return by value and therefore make a copy in the return statement. Plus, Unit and DType are immutable. So we strictly speaking don't even have to make a copy (at least in __copy__).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3865