Repository navigation
Fix time-of-check / time-of-use mistake with dim labels - #3882
Merged
Merged
Conversation
SimonHeybrock
left a comment
SimonHeybrock
left a comment
Member
There was a problem hiding this comment.
Aside from the unrelated changes in the branch, the actual fix looks correct. Should we avoid the duplicate code?
Member
Author
|
Oops, I accidentally included changes from #3877. We can just merge that first to clean up the diff. |
jl-wynen
force-pushed
the
fix-toctou-mistake
branch
from
April 13, 2026 07:42
9879626 to
2b31562
Compare
Member
Author
|
@SimonHeybrock Can you take another look? |
SimonHeybrock
approved these changes
Apr 14, 2026
jl-wynen
enabled auto-merge
April 14, 2026 07:27
jl-wynen
force-pushed
the
fix-toctou-mistake
branch
from
April 14, 2026 07:27
2b31562 to
c19babd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3881