Repository navigation
Guard SubbinSizes::exclusive_scan against negative delta - #3885
Merged
SimonHeybrock merged 4 commits intoApr 15, 2026
Merged
Conversation
Add a check that throws std::logic_error if x.offset() < offset(), which would cause an out-of-bounds read at a negative index. Analysis of the binning pipeline confirms this cannot happen in practice (sorted-input preconditions guarantee non-decreasing offsets), so existing results are unaffected. The guard turns latent UB into an explicit error if assumptions ever break. Closes #3879 Co-Authored-By: Claude Opus 4.6 <[email protected]>
nvaytet
approved these changes
Apr 13, 2026
SimonHeybrock
enabled auto-merge
April 13, 2026 08:56
SimonHeybrock
deleted the
fix-subbin-sizes-exclusive-scan-negative-delta
branch
April 15, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubbinSizes::exclusive_scanhad a potential out-of-bounds read whenx.offset() < offset()(negative delta). The>= osizecheck does not catch negative indices, leading to UB.std::logic_errorguard so the UB becomes an explicit error if assumptions ever break.Closes #3879
🤖 Generated with Claude Code