Repository navigation
Fix ElementArrayView lifetime issues with Python - #3895
Merged
Merged
Conversation
nvaytet
approved these changes
May 4, 2026
| .def("__iter__", [](const ElementArrayView<T> &self) { | ||
| return py::make_iterator(self.begin(), self.end()); | ||
| }); | ||
| py::keep_alive<0, 1>()); |
Member
There was a problem hiding this comment.
The diff is confusing, but am I right that adding keep_alive here is the only bit that has changed?
Member
Author
There was a problem hiding this comment.
No, __getitem__ used to have py::return_value_policy::reference) but I removed that. We don't need it because it returns a Python object anyway and copying/moving that handles reference counts automatically.
nvaytet
approved these changes
May 4, 2026
ElementArrayView is only used for Python objects. Those are not copied here anyway. So there is no need for `return_value_policy::reference`, just let Python ref counting do its job.
jl-wynen
enabled auto-merge
May 4, 2026 08:54
jl-wynen
force-pushed
the
no-tmp-ref-return
branch
from
May 4, 2026 08:54
71ff472 to
8092c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3894