Skip to content

pytest doesnt like iterables while parametrizing - #3907

Merged
MridulS merged 4 commits into
scipp:mainfrom
MridulS:fix_pytest_warnings
Jun 18, 2026
Merged

MridulS merged 4 commits into
scipp:mainfrom
MridulS:fix_pytest_warnings

Conversation

@MridulS

@MridulS MridulS commented Jun 18, 2026

Copy link
Copy Markdown
Member

Our nightly release pipeline was broken at the test part due to this.

https://github.com/scipp/scipp/actions/workflows/release-nightly.yml

@MridulS
MridulS requested a review from YooSunYoung June 18, 2026 08:38
@jl-wynen

Copy link
Copy Markdown
Member

Why does this only show up in the nightly pipeline? Do we use an old pytest version?

@MridulS

MridulS commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Yes - the warning came in pytest 9.1.0 and we are pinned to 9.0.2 right now https://github.com/scipp/scipp/blob/main/requirements/test.txt

@nvaytet

nvaytet commented Jun 18, 2026

Copy link
Copy Markdown
Member

Is it worth running the nightly job from this branch to 'prove' that this indeed has fixed the issue?

@jl-wynen

Copy link
Copy Markdown
Member

Yes - the warning came in pytest 9.1.0 and we are pinned to 9.0.2 right now https://github.com/scipp/scipp/blob/main/requirements/test.txt

So it used to work but no longer?

@MridulS

MridulS commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Yup - https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators

@MridulS

MridulS commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Is it worth running the nightly job from this branch to 'prove' that this indeed has fixed the issue?

The wheel building works fine now https://github.com/scipp/scipp/actions/runs/27748287499/job/82091967848?pr=3907
The failure is the upload failure (as it should)

This reverts commit 2ef8cf3.
@MridulS
MridulS enabled auto-merge (squash) June 18, 2026 12:19
@MridulS
MridulS merged commit b3ad0c1 into scipp:main Jun 18, 2026
4 checks passed
@jl-wynen jl-wynen mentioned this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants