Repository navigation
Support f-string formatting of long str-arrays - #3911
Merged
Merged
Conversation
jl-wynen
force-pushed
the
fix-fstring-long-string-arrays
branch
from
June 22, 2026 08:25
98938a3 to
7567928
Compare
nvaytet
reviewed
Jul 2, 2026
| elements.extend(_format_all_in(data[right])) | ||
| if right != range(0, 0): | ||
| elements.extend(_format_all_in(data, right)) | ||
| return f'[{", ".join(elements)}]' |
Member
There was a problem hiding this comment.
Should we add a small test that just tries to make a f-string and just make sure it doesn't raise?
jl-wynen
force-pushed
the
fix-fstring-long-string-arrays
branch
from
July 2, 2026 14:10
de0e4d1 to
e5990ff
Compare
nvaytet
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3910