Skip to content

MAINT: TBB bump to 2023.0.0 - #3916

Merged
MridulS merged 6 commits into
mainfrom
tbb_2023
Jul 30, 2026
Merged

MridulS merged 6 commits into
mainfrom
tbb_2023

Conversation

@MridulS

@MridulS MridulS commented Jun 25, 2026 •

Copy link
Copy Markdown
Member

Fixes #3917

@jl-wynen

jl-wynen commented Jul 1, 2026

Copy link
Copy Markdown
Member

Builds are currently broken because of #3918, need to wait for #3920

@jl-wynen

jl-wynen commented Jul 1, 2026

Copy link
Copy Markdown
Member

The wheel build on windows is failing with

*** Making wheel...
2026-07-01T13:53:35.7687720Z *** Created scipp-26.3.2.dev46+g30593e01b-cp311-cp311-win_amd64.whl
2026-07-01T13:53:35.9450062Z Successfully built scipp-26.3.2.dev46+g30593e01b-cp311-cp311-win_amd64.whl
2026-07-01T13:53:36.0120088Z ##[endgroup]
2026-07-01T13:53:36.0122044Z                                                            �[32m✓ �[0m1492.51s
2026-07-01T13:53:36.0123020Z ##[group]Repairing wheel...
2026-07-01T13:53:36.0123267Z 
2026-07-01T13:53:36.0127548Z + delvewheel repair -w C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\repaired_wheel -v C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\built_wheel\scipp-26.3.2.dev46+g30593e01b-cp311-cp311-win_amd64.whl
2026-07-01T13:53:39.4985323Z Traceback (most recent call last):
2026-07-01T13:53:39.4993876Z   File "<frozen runpy>", line 198, in _run_module_as_main
2026-07-01T13:53:39.4994456Z   File "<frozen runpy>", line 88, in _run_code
2026-07-01T13:53:39.4995449Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\build\venv\Scripts\delvewheel.exe\__main__.py", line 5, in <module>
2026-07-01T13:53:39.4996715Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\build\venv\Lib\site-packages\delvewheel\__main__.py", line 129, in main
2026-07-01T13:53:39.4997995Z     wr.repair(args.target, no_mangles, args.no_mangle_all, args.with_mangle, args.strip, args.lib_sdir, not args.no_diagnostic and 'SOURCE_DATE_EPOCH' not in os.environ, namespace_pkgs, args.include_symbols, args.include_imports, args.custom_patch)
2026-07-01T13:53:39.4999788Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\build\venv\Lib\site-packages\delvewheel\_wheel_repair.py", line 849, in repair
2026-07-01T13:53:39.5000823Z     discovered, associated, ignored = _dll_utils.get_all_needed(executable_path, self._exclude, self._wheel_dirs, 'raise', include_symbols, include_imports)[:3]
2026-07-01T13:53:39.5001555Z                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2026-07-01T13:53:39.5002643Z   File "C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\build\venv\Lib\site-packages\delvewheel\_dll_utils.py", line 458, in get_all_needed
2026-07-01T13:53:39.5003425Z     raise FileNotFoundError(f'Unable to find library: {dll_name}')
2026-07-01T13:53:39.5003851Z FileNotFoundError: Unable to find library: scipp-dataset.dll
2026-07-01T13:53:40.6460720Z extracting scipp-26.3.2.dev46+g30593e01b-cp311-cp311-win_amd64.whl to C:\Users\RUNNER~1\AppData\Local\Temp\tmpkjt6yv6v
2026-07-01T13:53:40.6461707Z repairing C:\Users\runneradmin\AppData\Local\Temp\cibw-run-jvpad1g1\cp311-win_amd64\built_wheel\scipp-26.3.2.dev46+g30593e01b-cp311-cp311-win_amd64.whl
2026-07-01T13:53:40.6462337Z finding DLL dependencies
2026-07-01T13:53:40.6462632Z analyzing package-level extension module scipp\_scipp.pyd

Why is it building win_amd64? Should this be win64?

@MridulS
MridulS marked this pull request as ready for review July 29, 2026 13:41
@MridulS

MridulS commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

@MridulS

MridulS commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

All looks happy now btw https://github.com/scipp/scipp/actions/runs/30350775929

@MridulS
MridulS enabled auto-merge (squash) July 29, 2026 13:50
@MridulS
MridulS requested a review from SimonHeybrock July 29, 2026 13:50
@MridulS
MridulS merged commit 31bb0a9 into main Jul 30, 2026
4 checks passed
@MridulS
MridulS deleted the tbb_2023 branch July 30, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to TBB 2023

3 participants