Repository navigation
Fix scope css - #3922
Fix scope css#3922
Conversation
| box-sizing: border-box !important; | ||
| } | ||
|
|
||
| :scope .sc-header > label, |
There was a problem hiding this comment.
Are these :scope selectors required? From what I understand, the @scope is enough so that these rules only apply to our own elements.
There was a problem hiding this comment.
That's true, the :scope selectors are not to protect the outer page from our rules, it's a specificity "tie-breaker" to protect our settings from the outer scope. They could be removed and replaced with !important. But if we can get away with something more gentle, that seems good to me.
Seems like a misunderstanding on my part. Most of the :scope selectors here can probably be removed.
| grid-template-columns: | ||
| max-content max-content max-content max-content max-content max-content | ||
| max-content !important; | ||
| grid-template-areas: "name parent objtype shape dtype unit preview" !important; |
There was a problem hiding this comment.
Why did you remove this? Was this broken all along?
There was a problem hiding this comment.
Yes, the old grid-area rules were ignored because the identifiers were quoted, but that accidentally made the layout work, because then the content was then laid out according to the default layout.
But when this was fixed the rows started overlapping like this:
So for now I removed the templates since the layout seems to work anyway.
There was a problem hiding this comment.
And it looks fine in notebooks as well?
|
Rendered docs can be found here: https://remote-unzip.scipp.deno.net/scipp/scipp/fix-scope-css |
2 participants
Fixes #3921
This will break the repr in older browsers that don't support scope. But I don't think that is a problem.