Skip to content

Add more verbose message to attribute error - #264

Merged
SimonHeybrock merged 17 commits into
scipp:mainfrom
ggoneiESS:main
Feb 5, 2025
Merged

SimonHeybrock merged 17 commits into
scipp:mainfrom
ggoneiESS:main

Conversation

@ggoneiESS

Copy link
Copy Markdown
Contributor

It is often not enough to know that there is an error for specific instances - the path that is at issue also needs to be reported.

This is similar to #248 and so now most cases are covered it seems.

@SimonHeybrock SimonHeybrock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But could I ask you undo the reformat that changes all the quotes?

@ggoneiESS

Copy link
Copy Markdown
Contributor Author

yes, you may be able to see from the commits Ruff has kept to its name and not been smooth...should pass now and I've also added some additional paths for depends_on warnings

@SimonHeybrock SimonHeybrock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimonHeybrock
SimonHeybrock merged commit d46b491 into scipp:main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants