Skip to content

Lower bounds - #276

Merged
MridulS merged 3 commits into
mainfrom
lower-bounds
Jul 29, 2025
Merged

MridulS merged 3 commits into
mainfrom
lower-bounds

Conversation

@jokasimr

Copy link
Copy Markdown
Contributor

No description provided.

@MridulS
MridulS enabled auto-merge (squash) July 29, 2025 06:52
@MridulS
MridulS merged commit 60d6023 into main Jul 29, 2025
@MridulS
MridulS deleted the lower-bounds branch July 29, 2025 06:53
Comment thread pyproject.toml
"scipy",
"h5py",
"scipy>=1.10.0",
"h5py>=3.12",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if Mantid works with this? If so, remove

# On versions of h5py prior to 3.2, a TypeError occurs in some cases
# where h5py cannot broadcast data with e.g. shape (20, 1) to a buffer
# of shape (20,). Note that broadcasting (1, 20) -> (20,) does work
# (see https://github.com/h5py/h5py/pull/1796).
# Therefore, we manually squeeze here.
# A pin of h5py<3.2 is currently required by Mantid and hence scippneutron
# (see https://github.com/h5py/h5py/issues/1880#issuecomment-823223154)
# hence this workaround. Once we can use a more recent h5py with Mantid,
# this try/except can be removed.
else this needs to be reverted, I think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was fixed in mantid in mantidproject/mantid#34806 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants