Repository navigation
MAINT: fix use of unique(..., return_inverse=True) - #19868
Merged
Merged
Conversation
Code was written to expect a 1-D array with the inverse indices, and that got changed in NumPy in numpy/numpy#25553. Closes scipygh-19867 [skip cirrus] [skip circle]
github-actions
Bot
added
scipy.interpolate
scipy.ndimage
maintenance
lucascolley
approved these changes
Jan 11, 2024
tylerjereddy
approved these changes
Jan 11, 2024
tylerjereddy
left a comment
tylerjereddy
left a comment
Contributor
There was a problem hiding this comment.
LGTM as well, and I reproduced 101 failures before/0 failures after the patch with NumPy main locally too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was written to expect a 1-D array with the inverse indices, and that got changed in NumPy in
numpy/numpy#25553.
Closes gh-19867