Repository navigation
DOC: Remove extra css colors and settings - #20460
Merged
Merged
Conversation
[docs only]
github-actions
Bot
added
the
Documentation
tupui
approved these changes
Apr 12, 2024
tupui
left a comment
tupui
left a comment
Member
There was a problem hiding this comment.
Awesome! Thanks Melissa. Will merge once green.
Member
Author
|
Forgot one thing: I also changed the try examples button to use the primary theme color. |
Member
|
All looks good to me 👍 merging, thanks again! |
This was referenced Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #19958
What does this implement/fix?
This PR removes many extra variables/settings in scipy.css which can now be inherited from the PyData Sphinx Theme.
To simplify the settings as much as possible, I've also made a few changes that I hope are not too disruptive:
I have added the text "SciPy" next to the logo on the top-left, and moved the version switcher to the right of the navigation bar.
The cards on the landing page are slightly different, relying on default settings for cards from sphinx-design (see above screenshot)
With the new theme, the fonts are slightly smaller which gives (at least to me) correct wrapping on the sidebar of the user guide, so I removed the special configuration that had been done there.
Dark mode and all colors now rely directly on the theme as much as possible.
For the version switcher, my suggestion is to not use a different color for stable, but I kept the orange for latest and red for older versions to highlight to users which version they are looking at.