Skip to content

ci: no pre-merge coverage of the docs publish path #1103

Description

@nikagra

Docs / Build PR runs only make -C docs setupenv && make -C docs test. That target is a single-version sphinx-build; it never invokes docs/_utils/multiversion.sh, javadoc-multiversion.sh or javadoc.sh, and the job installs no JDK 8.

So a typo in the per-branch JDK case list, a wrong JAVA_HOME_* variable name, or a bad relative path is only discovered after merge, on the publish workflow — which has a history of failing silently.

.github/workflows/docs-pr.yml also filters on docs/**, faq/**, manual/**, changelog/**, upgrade_guide/**, so a change confined to .github/workflows/** gets no check at all.

Fix: what #909 proposed — add make -C docs multiversion to the PR workflow, a JDK 8 setup-java step, and .github/workflows/** to its paths:. A full multiversion build is slow, so it may need to be opt-in by label or limited to a couple of representative branches.

Refs: https://scylladb.atlassian.net/browse/DRIVER-1086

Jira: https://scylladb.atlassian.net/browse/DRIVER-1089

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions