Skip to content

4.x: Fix metadata node events for null tablet map - #507

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/4.x-fix-tablets-2
Apr 7, 2025
Merged

dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/4.x-fix-tablets-2

Conversation

@dkropachev

@dkropachev dkropachev commented Apr 7, 2025 •

Copy link
Copy Markdown

After #505 tablet map could be empty, we need to address these cases.

@dkropachev
dkropachev force-pushed the dk/4.x-fix-tablets-2 branch from de889b1 to e64020c Compare April 7, 2025 11:57
@dkropachev
dkropachev requested a review from Bouncheck April 7, 2025 11:57

@Bouncheck Bouncheck left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not going to be an Optional<TabletMap> after #505?
Shouldnt there be a .get()?

@dkropachev

Copy link
Copy Markdown
Author

Is this not going to be an Optional<TabletMap> after #505? Shouldnt there be a .get()?

it is stored as TabletMap and converted to Optional only at getTabletMap

Tablet map could be empty, we need to address these cases.
@dkropachev
dkropachev force-pushed the dk/4.x-fix-tablets-2 branch from e64020c to f21dff0 Compare April 7, 2025 12:28
@Bouncheck
Bouncheck self-requested a review April 7, 2025 12:41
@dkropachev
dkropachev merged commit c3d8010 into scylladb:scylla-4.x Apr 7, 2025
@dkropachev dkropachev self-assigned this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants