"csvtk --show-row-number concat" does not print row number column. #360

Activity

1. shenwei356 commented on May 2, 2026

   

   shenwei356

   on May 2, 2026

   Owner

   More actions

   Only a few commands support that flag (see the appendix below). And other commands needing the row number can be piped to one of these commands, like

   $ printf "a,b\n1,2\n" | csvtk concat - <(printf "a,b\n10,20\n") | csvtk cut -f 1- -Z
   row,a,b
   1,1,2
   2,10,20
   

   But I've enabled concat to support it now.

   $ printf "a,b\n1,2\n" | csvtk concat - <(printf "a,b\n10,20\n") -Z
   row,a,b
   1,1,2
   2,10,20
   
   $ printf "a,b\n1,2\n" | csvtk concat - <(printf "a,b\n10,20\n") -Z -H
   1,a,b
   2,1,2
   3,a,b
   4,10,20
   
   $ printf "a,b\n1,2\n" | csvtk concat - <(printf "a,b\n10,20\n") -U
   1,2
   10,20
   
   $ printf "a,b\n1,2\n" | csvtk concat - <(printf "a,b\n10,20\n") -Z -U
   1,1,2
   2,10,20
   

   I also make concat accept one input file now.

   $ printf "a,b\n1,2\n" | csvtk concat -Z
   row,a,b
   1,1,2
   

   • csvtk_darwin_arm64.tar.gz
   • csvtk_linux_amd64.tar.gz
   • csvtk_windows_amd64.exe.tar.gz

   appendix:

   $ rg config.ShowRowNumber
   csvtk/cmd/csv2xlsx.go
   91:                             ShowRowNumber: config.ShowRowNumber,
   
   csvtk/cmd/sample.go
   96:                             ShowRowNumber: printLineNumber || config.ShowRowNumber,
   
   csvtk/cmd/pretty.go
   210:                    ShowRowNumber: config.ShowRowNumber,
   286:                            if config.ShowRowNumber {
   295:                                            if config.ShowRowNumber {
   303:                                            if config.ShowRowNumber {
   318:                                            if config.ShowRowNumber {
   355:                                            if config.ShowRowNumber {
   373:                                            if config.ShowRowNumber {
   
   csvtk/cmd/cut.go
   126:                    ShowRowNumber:      config.ShowRowNumber,
   
   csvtk/cmd/csv2tab.go
   68:                             ShowRowNumber: config.ShowRowNumber,
   
   csvtk/cmd/filter2.go
   193:            showRowNumber := printLineNumber || config.ShowRowNumber
   
   csvtk/cmd/head.go
   71:             printLineNumber := config.ShowRowNumber
   
   csvtk/cmd/del-quotes.go
   76:                     ShowRowNumber: config.ShowRowNumber,
   
   csvtk/cmd/filter.go
   97:             showRowNumber := printLineNumber || config.ShowRowNumber
   
   csvtk/cmd/tab2csv.go
   69:                             ShowRowNumber: config.ShowRowNumber,
   
   csvtk/cmd/grep.go
   82:             printLineNumber := getFlagBool(cmd, "line-number") || config.ShowRowNumber
   
   
2. derekmahar commented on May 2, 2026

   

   derekmahar

   on May 2, 2026

   Author

   More actions

   Thank you for this change. This will resolve the inconsistency between csvtk concat --show-row-number and its help documentation (--help) which specifies that --show-row-number is a global flag which applies to all commands.

   In csvtk v0.37.0 and earlier, does csvtk concat require at least two input files? Like in my example above, I've often used that command with only one input source, usually standard input.
3. shenwei356 commented on May 2, 2026

   

   shenwei356

   on May 2, 2026

   Owner

   More actions

   It accepts one file before but needs to load all data in memory and then dump to output. Today's change make it more menory-effcient.

   👍React with 👍1Reacted by Derek Mahar
4. shenwei356

   closed this as completedon Sep 18, 2026