Repository navigation
Support Request Initiator metadata extension - #232
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
============================================
+ Coverage 88.71% 90.15% +1.43%
- Complexity 2377 3561 +1184
============================================
Files 161 166 +5
Lines 5780 8526 +2746
============================================
+ Hits 5128 7687 +2559
- Misses 652 839 +187 |
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
June 13, 2020 20:12
2ad5606 to
5a03b3b
Compare
tvdijen
commented
Jun 15, 2020
jaimeperez
reviewed
Jul 1, 2020
| * @param string $binding | ||
| * @throws \InvalidArgumentException if the Binding is empty | ||
| */ | ||
| protected function setBinding(string $binding): void |
Member
There was a problem hiding this comment.
Considering the binding is fixed, does it make sense having a setBinding() method?
Member
Author
There was a problem hiding this comment.
I thought it would make sense to keep the constructor the same as for other AbstractEndpoints.
The alternative is overriding the constructor.. But that would mean also overriding the fromXML-method
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
jaimeperez
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.