Skip to content

feat: add is_mcp_enabled setting to app manifest - #513

Merged
mwbrooks merged 4 commits into
mainfrom
mwbrooks-manifest-is_mcp_enabled
Apr 30, 2026
Merged

feat: add is_mcp_enabled setting to app manifest#513
mwbrooks merged 4 commits into
mainfrom
mwbrooks-manifest-is_mcp_enabled

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changelog

Add support for the settings.is_mcp_enabled: <bool> manifest property to enable or disable the Slack MCP Server.

Summary

This pull request adds the settings.is_mcp_enabled boolean field to the AppSettings manifest type. When omitted, the backend defaults to false.

Testing

# Create a new Agent app
$ lack create agent

# Update the manifest.json with `settings.is_mcp_enabled: true`
$ vim manifest.json
# → Add `settings.is_mcp_enabled: true`

# Install the app
$ lack run
# → CTRL+C

# Confirm the MCP is enabled
$ lack app settings
# → Select "AI & Agents" on left-nav
# → Scroll to bottom and confirm MCP is enabled

Notes

Follows the existing *bool + omitempty pattern used by other boolean settings (socket_mode_enabled, org_deploy_enabled, token_rotation_enabled).

Requirements

@mwbrooks mwbrooks self-assigned this Apr 29, 2026
@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment changelog Use on updates to be included in the release notes labels Apr 29, 2026
@mwbrooks mwbrooks added this to the Next Release milestone Apr 29, 2026
@codecov

codecov Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.26%. Comparing base (d2ab928) to head (48c0231).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   71.26%   71.26%           
=======================================
  Files         222      222           
  Lines       18682    18682           
=======================================
  Hits        13314    13314           
- Misses       4187     4189    +2     
+ Partials     1181     1179    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks
mwbrooks marked this pull request as ready for review April 29, 2026 05:11
@mwbrooks
mwbrooks requested a review from a team as a code owner April 29, 2026 05:11
zimeg
zimeg approved these changes Apr 30, 2026
View reviewed changes

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks So nice! 💃 🤖 🕺 🪩 ✨

@mwbrooks

mwbrooks commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

Thanks a bunch @zimeg! 🙇🏻

@mwbrooks
mwbrooks merged commit 783ac1a into main Apr 30, 2026
8 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-manifest-is_mcp_enabled branch April 30, 2026 18:43
@zimeg zimeg mentioned this pull request Oct 1, 2026
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@mwbrooks mwbrooks

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mwbrooks @zimeg