Repository navigation
add defaultSetCookie - #16
Merged
Merged
Conversation
Owner
|
Looks good, thanks! Can you add |
Contributor
Author
|
Cool, done. |
snoyberg
requested changes
Nov 7, 2017
| @@ -1,5 +1,5 @@ | |||
| name: cookie | |||
| version: 0.4.2.1 | |||
| version: 0.4.2.2 | |||
Owner
There was a problem hiding this comment.
Sorry, I should have clarified. Since this is adding a new identifier, this needs to be a minor version bump, not a patch. Meaning: the new version number would be 0.4.3.
Contributor
Author
There was a problem hiding this comment.
Ah yes sorry, I misread the PVP spec. Updated.
snoyberg
approved these changes
Nov 7, 2017
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, would you mind accepting this monomorphic alternative to
deffor the baseSetCookievalue? I don't think theDefaultclass is really helpful for most use cases here, so it would be nice for the library to provide this value more directly in non-overloaded form.I also added a bit of documentation explaining what field values
defaultSetCookiecontains.