Repository navigation
Change hashtable to use OrdinalIgnoreCase to be case-insensitive in all Cultures - #3
Open
TommiTallgren wants to merge 3 commits into
Open
TommiTallgren wants to merge 3 commits into
TommiTallgren wants to merge 3 commits into
Conversation
….Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>
….Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>
Softagram Impact Report for pull/3 (head commit: 6e4faa0)⭐ Visual OverviewChanged elements and changed dependencies. ⭐ Change ImpactHow the changed files are used by the rest of the project 📄 Full report
Give feedback of this report to [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Ubuntu18.04 seems to default to
C.UTF-8for LANG (representing InvariantCulture) which results in a case-sensitive hashtable since CurrentCultureIgnoreCase doesn't work for that culture. Fix is to use OrdinalIgnoreCase instead.Fix PowerShell#7761
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests