Repository navigation
Add rule to sort class methods by their modifiers and usage in other methods #16
Description
There are already rules that enforce following order:
- attributes
- getters/setters
- constructor
- methods
I propose to make it stricter and enforce order of methods:
- attributes
- public getters/setters
- private getters/setters?
- constructor
- overrides
- public methods*
- private methods*
* - can go above in order if they go just after method they are used in
BAD:
_privateMethod() {
...
}
publicMethod() {
...
}
@override
overwritenMethod() {
...
}GOOD:
@override
overwritenMethod() {
...
}
publicMethod() {
...
}
_privateMethod() {
...
}GOOD:
@override
overwritenMethod() {
...
_privateMethod();
...
}
_privateMethod() {
...
}
publicMethod() {
...
}
Activity
[-]Add rule to sort methods[/-][+]Add rule(s) to sort methods[/+][-]Add rule(s) to sort methods[/-][+]Add rule to sort class methods by their modifiers and usage in other methods[/+]illia-romanenko commentedon May 11, 2023
That would require a custom rule, correct?
ruslan-rudenko-solid commentedon May 15, 2023
There is an updated dcm functionality that I believe allows doing this
illia-romanenko commentedon May 15, 2023
It probably doesn't cover this case:
danylo-safonov-solid commentedon May 16, 2023
Yes, it doesn't seem to, but it allows to enforce privates/overrides, but I guess it's too strict without allowing the mixed order depending on usage?
More like a variant of existing one, but yes